From ba1d600cd8fff0db05cfd8a612b96012feff5b05 Mon Sep 17 00:00:00 2001
From: Christoph <ckubu@oopen.de>
Date: Mon, 20 Jul 2026 22:49:38 +0200
Subject: [PATCH] Refactor ansible tasks in apt-gateway.yml to include module
 prefixes and improve variable naming consistency

---
 roles/common/tasks/apt-gateway.yml | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/roles/common/tasks/apt-gateway.yml b/roles/common/tasks/apt-gateway.yml
index e7e33b3..a4d6704 100644
--- a/roles/common/tasks/apt-gateway.yml
+++ b/roles/common/tasks/apt-gateway.yml
@@ -1,30 +1,30 @@
 ---
 
 - name: (apt-gateway.yml) Install gateway related packages
-  apt:
+  ansible.builtin.apt:
     name: "{{ apt_gateway_host_pkgs }}"
     state: "{{ apt_install_state }}"
 
 
 - name: (apt-gateway.yml) Check if file '/etc/logrotate.d/speedtest' exists
-  stat:
+  ansible.builtin.stat:
     path: /etc/logrotate.d/speedtest
-  register: logrotate_speedtest_exists
+  register: common_logrotate_speedtest_exists
 
 
 - name: (apt-gateway.yml) Ensure file /etc/logrotate.d/speedtest exists
-  copy:
+  ansible.builtin.copy:
     src: "{{ role_path + '/files/etc/logrotate.d/speedtest' }}"
     dest: /etc/logrotate.d/speedtest
     owner: root
     group: root
-    mode: 0644
-  when:  
-    - logrotate_speedtest_exists.stat.exists == False
+    mode: '0644'
+  when:
+    - not common_logrotate_speedtest_exists.stat.exists
 
 
 - name: (apt-gateway.yml) Set crontab entry for nightly speedtests
-  cron:
+  ansible.builtin.cron:
     name: 'Speedtest'
     minute: 13
     hour: 0-8