Refactor Ansible tasks to use fully qualified module names and improve code consistency
- Updated all tasks to use fully qualified module names (e.g., ansible.builtin.shell, ansible.builtin.copy) for clarity and to avoid ambiguity. - Replaced deprecated 'yum' module with 'dnf' for package management on RedHat-based systems. - Improved formatting and consistency in task definitions, including the use of double quotes for strings and consistent indentation. - Removed unnecessary comments and whitespace to enhance readability. - Ensured that conditions and loops are consistently formatted across all tasks.
This commit is contained in:
+21
-27
@@ -1,11 +1,10 @@
|
||||
---
|
||||
|
||||
# ---
|
||||
# NFS Server
|
||||
# ---
|
||||
|
||||
- name: (nfs.yml) Ensure NFS utilities (server) are installed.
|
||||
apt:
|
||||
ansible.builtin.apt:
|
||||
name:
|
||||
- nfs-common
|
||||
- nfs-kernel-server
|
||||
@@ -17,27 +16,27 @@
|
||||
- nfs-server
|
||||
|
||||
- name: (nfs.yml) Ensure directories to export exist
|
||||
file:
|
||||
ansible.builtin.file:
|
||||
path: '{{ item.src.split(":")[1] }}'
|
||||
owner: root
|
||||
group: root
|
||||
mode: '0755'
|
||||
mode: "0755"
|
||||
state: directory
|
||||
with_items: "{{ nfs_exports }}"
|
||||
loop_control:
|
||||
label: '{{ item.path }}'
|
||||
label: "{{ item.path }}"
|
||||
when:
|
||||
- "groups['nfs_server']|string is search(inventory_hostname)"
|
||||
tags:
|
||||
- nfs-server
|
||||
|
||||
- name: (nfs.yml) Copy exports file.
|
||||
template:
|
||||
ansible.builtin.template:
|
||||
src: etc/exports.j2
|
||||
dest: /etc/exports
|
||||
owner: root
|
||||
group: root
|
||||
mode: 0644
|
||||
mode: "0644"
|
||||
when:
|
||||
- "groups['nfs_server']|string is search(inventory_hostname)"
|
||||
notify: Reload nfs
|
||||
@@ -45,15 +44,15 @@
|
||||
- nfs-server
|
||||
|
||||
- name: Enable service rpc-statd and ensure it is not masked
|
||||
systemd:
|
||||
ansible.builtin.systemd:
|
||||
name: rpc-statd
|
||||
enabled: yes
|
||||
masked: no
|
||||
enabled: true
|
||||
masked: false
|
||||
when:
|
||||
- "groups['nfs_server']|string is search(inventory_hostname)"
|
||||
|
||||
- name: Make sure service rpc-statd is running
|
||||
systemd:
|
||||
ansible.builtin.systemd:
|
||||
state: started
|
||||
name: rpc-statd
|
||||
when:
|
||||
@@ -66,7 +65,7 @@
|
||||
# ---
|
||||
|
||||
- name: (nfs.yml) Check if file '/etc/default/nfs-kernel-server.ORIG' exists
|
||||
stat:
|
||||
ansible.builtin.stat:
|
||||
path: /etc/default/nfs-kernel-server
|
||||
register: default_nfs_kernel_server_exists
|
||||
when:
|
||||
@@ -75,7 +74,7 @@
|
||||
- nfs-server
|
||||
|
||||
- name: (nfs.yml) Backup existing file /etc/default/nfs-kernel-server
|
||||
command: cp -a /etc/default/nfs-kernel-server /etc/default/nfs-kernel-server.ORIG
|
||||
ansible.builtin.command: cp -a /etc/default/nfs-kernel-server /etc/default/nfs-kernel-server.ORIG
|
||||
when:
|
||||
- "groups['nfs_server']|string is search(inventory_hostname)"
|
||||
- default_nfs_kernel_server_exists.stat.exists == False
|
||||
@@ -83,9 +82,9 @@
|
||||
- nfs-server
|
||||
|
||||
- name: (nfs.yml) Adjust file /etc/default/nfs-kernel-server - set 'RPCNFSDCOUNT' (server)
|
||||
replace:
|
||||
ansible.builtin.replace:
|
||||
path: /etc/default/nfs-kernel-server
|
||||
regexp: '^RPCNFSDCOUNT=.*'
|
||||
regexp: "^RPCNFSDCOUNT=.*"
|
||||
replace: "RPCNFSDCOUNT={{ nfs_start_servers | default('16') }}"
|
||||
when:
|
||||
- "groups['nfs_server']|string is search(inventory_hostname)"
|
||||
@@ -97,10 +96,10 @@
|
||||
# ---
|
||||
|
||||
- name: (nfs.yml) Ensure directory '/etc/nfs.conf.d' exists
|
||||
file:
|
||||
ansible.builtin.file:
|
||||
path: /etc/nfs.conf.d
|
||||
state: directory
|
||||
mode: 0755
|
||||
mode: "0755"
|
||||
group: root
|
||||
owner: root
|
||||
when:
|
||||
@@ -108,30 +107,28 @@
|
||||
tags:
|
||||
- nfs-server
|
||||
|
||||
|
||||
- name: (nfs.yml) Create/Update file '/etc/nfs.conf.d/20-start_servers.conf' from template '20-start_servers.conf.j2'
|
||||
template:
|
||||
ansible.builtin.template:
|
||||
src: etc/nfs.conf.d/20-start_servers.conf.j2
|
||||
dest: /etc/nfs.conf.d/20-start_servers.conf
|
||||
owner: root
|
||||
group: root
|
||||
mode: 0644
|
||||
mode: "0644"
|
||||
notify: "Restart nfs-kernel-server"
|
||||
when:
|
||||
- inventory_hostname in groups['nfs_server']
|
||||
tags:
|
||||
- nfs-server
|
||||
|
||||
|
||||
# ---
|
||||
# NFS clients
|
||||
# ---
|
||||
|
||||
- name: (nfs.yml) Ensure NFS utilities (clients) are installed.
|
||||
apt:
|
||||
ansible.builtin.apt:
|
||||
pkg: nfs-common
|
||||
state: present
|
||||
when:
|
||||
when:
|
||||
- ansible_facts['os_family'] == "Debian"
|
||||
- "groups['nfs_client']|string is search(inventory_hostname)"
|
||||
tags:
|
||||
@@ -148,11 +145,8 @@
|
||||
state: mounted
|
||||
loop: "{{ nfs_exports }}"
|
||||
loop_control:
|
||||
label: '{{ item.src }}'
|
||||
label: "{{ item.src }}"
|
||||
when:
|
||||
- "groups['nfs_client']|string is search(inventory_hostname)"
|
||||
tags:
|
||||
- nfs-client
|
||||
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user