Refactor Ansible tasks and templates for improved consistency and clarity

roles/common/tasks/nis-user.yml

@@ -33,7 +33,7 @@
 # ---
 
 - name: (nis_user.yml) Ensure nis groups exists
-  group:
+  ansible.builtin.group:
     name: '{{ item.name }}'
     state: present
     gid: '{{ item.group_id | default(omit) }}'
@@ -45,18 +45,19 @@
   tags:
     - nis-user
     - system-user
-    
-#- meta: end_host
+
+# - meta: end_host
 
 - name: (nis_user.yml) Get database of nis (system) users
-  getent:
+  ansible.builtin.getent:
     database: passwd
   tags:
     - nis-user
     - system-user
 
 - name: (nis_user.yml) Add nis (system) users if not yet exists..
-  shell: "/root/bin/admin-stuff/add_new_user.sh {{ item.name }} '{{ item.password }}'"
+  ansible.builtin.command: "/root/bin/admin-stuff/add_new_user.sh {{ item.name }} '{{ item.password }}'"
+  changed_when: true
   loop: "{{ nis_user }}"
   loop_control:
     label: '{{ item.name }}'
@@ -69,17 +70,17 @@
     - system-user
 
 - name: (nis_user.yml) Ensure nis users exists
-  user:
+  ansible.builtin.user:
     name: '{{ item.name }}'
     state: present
     uid: '{{ item.user_id | default(omit) }}'
-    #group: '{{ item.0.name | default(omit) }}'
-    groups: "{{ item.groups|join(', ') }}"
+    # group: '{{ item.0.name | default(omit) }}'
+    groups: "{{ item.groups | join(', ') }}"
     home: '{{ nis_base_home }}/{{ item.name }}'
-    shell: '{{ item.shell|d("/bin/bash") }}'
+    shell: '{{ item.shell | d("/bin/bash") }}'
     password: "{{ item.password | password_hash('sha512') }}"
     update_password: on_create
-    append: yes
+    append: true
   loop: "{{ nis_user }}"
   loop_control:
     label: '{{ item.name }}'
@@ -90,42 +91,42 @@
 
 
 - name: (nis_user.yml) Check if directory ~/.config/autostart exists
-  stat:
+  ansible.builtin.stat:
     path: '{{ nis_base_home }}/{{ item.name }}/.config/autostart'
   loop: "{{ nis_user }}"
   loop_control:
     label: '{{ item.name }}'
-  register: home_config_autostart
+  register: common_home_config_autostart
   tags:
     - nis-user
     - x11vnc
 
 
 - name: (nis_user.yml) Ensure directory ~/.config/autostart if not exists
-  file:
+  ansible.builtin.file:
     path: '{{ nis_base_home }}/{{ item.item.name }}/.config/autostart'
     state: directory
     owner: "{{ item.item.name }}"
     group: "{{ item.item.name }}"
-    mode: 0700
-    recurse: yes
-  loop: "{{ home_config_autostart.results }}"
+    mode: "0700"
+    recurse: true
+  loop: "{{ common_home_config_autostart.results }}"
   loop_control:
     label: '{{ item.item.name }}'
-  when : not item.stat.exists|bool
+  when: not item.stat.exists|bool
   tags:
     - nis-user
     - x11vnc
 
 
-#- name: (nis_user.yml) Ensure directory ~/.config/autostart if not exists
+# - name: (nis_user.yml) Ensure directory ~/.config/autostart if not exists
 #  file:
 #    path: '{{ nis_base_home }}/{{ item.name }}/.config/autostart'
 #    state: directory
 #    owner: "{{ item.name }}"
 #    group: "{{ item.name }}"
-#    mode: 0700
-#    recurse: yes
+#    mode: "0700"
+#    recurse: true
 #  loop: "{{ nis_user }}"
 #  loop_control:
 #    label: '{{ item.name }}'
@@ -135,42 +136,40 @@
 
 
 - name: (nis_user.yml) Check if file ~/.config/autostart/x11vnc.desktop exists
-  stat:
+  ansible.builtin.stat:
     path: '{{ nis_base_home }}/{{ item.name }}/.config/autostart/x11vnc.desktop'
   loop: "{{ nis_user }}"
   loop_control:
     label: '{{ item.name }}'
-  register: home_config_autostart_x11vnc
+  register: common_home_config_autostart_x11vnc
   tags:
     - nis-user
     - x11vnc
 
 - name: (nis_user.yml) Ensure file ~/.config/autostart/x11vnc.desktop exists
-  copy:
+  ansible.builtin.copy:
     src: "{{ role_path + '/files/USER_HOME/.config/autostart/x11vnc.desktop' }}"
     dest: '{{ nis_base_home }}/{{ item.item.name }}/.config/autostart/x11vnc.desktop'
     owner: '{{ item.item.name }}'
     group: '{{ item.item.name }}'
-    mode: 0600
-  loop: "{{ home_config_autostart_x11vnc.results }}"
+    mode: "0600"
+  loop: "{{ common_home_config_autostart_x11vnc.results }}"
   loop_control:
     label: '{{ item.item.name }}'
   tags:
     - nis-user
     - x11vnc
 
-#- name: (nis_user.yml) Ensure file ~/.config/autostart/x11vnc.desktop exists
+# - name: (nis_user.yml) Ensure file ~/.config/autostart/x11vnc.desktop exists
 #  copy:
 #    src: "{{ role_path + '/files/USER_HOME/.config/autostart/x11vnc.desktop' }}"
 #    dest: '{{ nis_base_home }}/{{ item.name }}/.config/autostart/x11vnc.desktop'
 #    owner: '{{ item.name }}'
 #    group: '{{ item.name }}'
-#    mode: 0600
+#    mode: "0600"
 #  loop: "{{ nis_user }}"
 #  loop_control:
 #    label: '{{ item.name }}'
 #  tags:
 #    - nis-user
 #    - x11vnc
-
-