Refactor Ansible tasks and templates for improved consistency and clarity

roles/common/tasks/nfs.yml

@@ -5,7 +5,7 @@
 # ---
 
 - name: (nfs.yml) Ensure NFS utilities (server) are installed.
-  apt:
+  ansible.builtin.apt:
     name:
       - nfs-common
       - nfs-kernel-server
@@ -17,7 +17,7 @@
     - nfs-server
 
 - name: (nfs.yml) Ensure directories to export exist
-  file:
+  ansible.builtin.file:
     path: '{{ item.src.split(":")[1] }}'
     owner: root
     group: root
@@ -37,7 +37,7 @@
     dest: /etc/exports
     owner: root
     group: root
-    mode: 0644
+    mode: "0644"
   when:
     - inventory_hostname in groups['nfs_server']
   notify: Reload nfs
@@ -45,15 +45,15 @@
     - nfs-server
 
 - name: Enable service rpc-statd and ensure it is not masked
-  systemd:
+  ansible.builtin.systemd:
     name: rpc-statd
-    enabled: yes
-    masked: no
+    enabled: true
+    masked: false
   when:
     - inventory_hostname in groups['nfs_server']
 
 - name: Make sure service rpc-statd is running
-  systemd:
+  ansible.builtin.systemd:
     state: started
     name: rpc-statd
   when:
@@ -66,24 +66,31 @@
 # ---
 
 - name: (nfs.yml) Check if file '/etc/default/nfs-kernel-server.ORIG' exists
-  stat:
+  ansible.builtin.stat:
     path: /etc/default/nfs-kernel-server
-  register: default_nfs_kernel_server_exists
+  register: common_default_nfs_kernel_server_exists
   when:
     - inventory_hostname in groups['nfs_server']
   tags:
     - nfs-server
 
 - name: (nfs.yml) Backup existing file /etc/default/nfs-kernel-server
-  command: cp -a /etc/default/nfs-kernel-server /etc/default/nfs-kernel-server.ORIG
+  ansible.builtin.copy:
+    src: /etc/default/nfs-kernel-server
+    dest: /etc/default/nfs-kernel-server.ORIG
+    remote_src: true
+    force: false
+    owner: root
+    group: root
+    mode: "0644"
   when:
     - inventory_hostname in groups['nfs_server']
-    - default_nfs_kernel_server_exists.stat.exists == False
+    - common_default_nfs_kernel_server_exists.stat.exists
   tags:
     - nfs-server
 
 - name: (nfs.yml) Adjust file /etc/default/nfs-kernel-server - set 'RPCNFSDCOUNT' (server)
-  replace:
+  ansible.builtin.replace:
     path: /etc/default/nfs-kernel-server
     regexp: '^RPCNFSDCOUNT=.*'
     replace: "RPCNFSDCOUNT={{ nfs_start_servers | default('16') }}"
@@ -97,10 +104,10 @@
 # ---
 
 - name: (nfs.yml) Ensure directory '/etc/nfs.conf.d' exists
-  file:
+  ansible.builtin.file:
     path: /etc/nfs.conf.d
     state: directory
-    mode: 0755
+    mode: "0755"
     group: root
     owner: root
   when:
@@ -115,7 +122,7 @@
     dest: /etc/nfs.conf.d/20-start_servers.conf
     owner: root
     group: root
-    mode: 0644
+    mode: "0644"
   notify: "Restart nfs-kernel-server"
   when:
     - inventory_hostname in groups['nfs_server']
@@ -128,17 +135,17 @@
 # ---
 
 - name: (nfs.yml) Ensure NFS utilities (clients) are installed.
-  apt:
+  ansible.builtin.apt:
     pkg: nfs-common
     state: present
-  when: 
+  when:
     - ansible_facts['os_family'] == "Debian"
     - inventory_hostname in groups['nfs_client']
   tags:
     - nfs-client
 
 - name: (nfs.yml) NFS Mount exports from nfs server
-  mount:
+  ansible.posix.mount:
     path: "{{ item.path }}"
     src: "{{ item.src }}"
     fstype: nfs
@@ -153,6 +160,3 @@
     - inventory_hostname in groups['nfs_client']
   tags:
     - nfs-client
-
-
-