Refactor Ansible tasks and templates for improved consistency and clarity

roles/common/tasks/basic.yml

@@ -1,22 +1,21 @@
 ---
 
 - name: (basic.yml) Ensure timezone is is correct
-  timezone: name={{ time_zone }}
+  community.general.timezone:
+    name: "{{ time_zone }}"
   tags:
     - timezone
 
-
 - name: (basic.yml) Ensure locales are present
-  locale_gen:
+  community.general.locale_gen:
     name: "{{ item }}"
     state: present
   with_items: "{{ locales }}"
   tags:
     - locales
 
-
 - name: (basic.yml) Create a symbolic link /bin/sh -> bash
-  file:
+  ansible.builtin.file:
     src: bash
     dest: /bin/sh
     owner: root
@@ -27,16 +26,15 @@
   tags:
     - symlink-sh
 
-
 # ----------
 # security limit (maybe DEPRECATED see systemd settings)
 # ----------
 
 - name: (basic.yml) Ensure directory '/etc/security/limits.d' exists
-  file:
+  ansible.builtin.file:
     path: /etc/security/limits.d
     state: directory
-    mode: 0755
+    mode: "0755"
     group: root
     owner: root
   when:
@@ -47,7 +45,7 @@
     - systemd-config
 
 - name: (basic.yml) Ensure files /etc/security/limits.d/*.conf exists
-  copy:
+  ansible.builtin.copy:
     src: '{{ item.src_path }}'
     dest: '{{ item.dest_path }}'
     owner: root
@@ -63,16 +61,15 @@
   tags:
     - systemd-config
 
-
 # ----------
 # systemd stuff
 # ----------
 
 - name: (basic.yml) Ensure directory '/etc/systemd/system.conf.d' exists
-  file:
+  ansible.builtin.file:
     path: /etc/systemd/system.conf.d
     state: directory
-    mode: 0755
+    mode: "0755"
     group: root
     owner: root
   when:
@@ -83,7 +80,7 @@
     - systemd-config
 
 - name: (basic.yml) Ensure files /etc/systemd/system.conf.d/*.conf exists
-  copy:
+  ansible.builtin.copy:
     src: '{{ item.src_path }}'
     dest: '{{ item.dest_path }}'
     owner: root
@@ -100,10 +97,10 @@
     - systemd-config
 
 - name: (basic.yml) Ensure directory '/etc/systemd/journald.conf.d' exists
-  file:
+  ansible.builtin.file:
     path: /etc/systemd/journald.conf.d
     state: directory
-    mode: 0755
+    mode: "0755"
     group: root
     owner: root
   when:
@@ -113,7 +110,7 @@
     - systemd-config
 
 - name: (basic.yml) Ensure files /etc/systemd/journald.conf.d/*.conf exists
-  copy:
+  ansible.builtin.copy:
     src: '{{ item.src_path }}'
     dest: '{{ item.dest_path }}'
     owner: root
@@ -129,45 +126,56 @@
   tags:
     - systemd-config
 
-
 # ----------
 # unattended upgrades
 # ----------
 
 - name: (basic.yml) install unattended-upgrades
-  apt: pkg=unattended-upgrades state=present
+  ansible.builtin.apt:
+    pkg: unattended-upgrades
+    state: present
   when:
     - ansible_facts['distribution'] == "Debian"
   tags:
     - unattended-upgrades
 
 - name: (basic.yml) install apt-listchanges
-  apt: pkg=apt-listchanges state=present
+  ansible.builtin.apt:
+    pkg: apt-listchanges
+    state: present
   when:
     - ansible_facts['distribution'] == "Debian"
   tags:
     - unattended-upgrades
 
 - name: (basic.yml) remove apticron
-  apt: pkg=apticron state=absent
+  ansible.builtin.apt:
+    pkg: apticron
+    state: absent
   when:
     - ansible_facts['distribution'] == "Debian"
   tags:
     - unattended-upgrades
 
 - name: (basic.yml) check if /etc/apt/apt.conf.d/20auto-upgrades exists
-  stat: path=/etc/apt/apt.conf.d/20auto-upgrades
-  register: ua_enabled
+  ansible.builtin.stat:
+    path: /etc/apt/apt.conf.d/20auto-upgrades
+  register: common_ua_enabled
   when:
     - ansible_facts['distribution'] == "Debian"
   tags:
     - unattended-upgrades
 
 - name: (basic.yml) activate unattended upgrades
-  shell: DEBIAN_FRONTEND=noninteractive DEBCONF_NONINTERACTIVE_SEEN=true dpkg-reconfigure -plow unattended-upgrades
+  ansible.builtin.command:
+    cmd: dpkg-reconfigure -plow unattended-upgrades
+    creates: /etc/apt/apt.conf.d/20auto-upgrades
+  environment:
+    DEBIAN_FRONTEND: noninteractive
+    DEBCONF_NONINTERACTIVE_SEEN: "true"
   when:
     - ansible_facts['distribution'] == "Debian"
-    - ua_enabled.stat.exists == False
+    - not common_ua_enabled.stat.exists
   tags:
     - unattended-upgrades
 
@@ -177,7 +185,7 @@
     dest: /etc/apt/listchanges.conf
     owner: root
     group: root
-    mode: 0644
+    mode: "0644"
   when:
     - ansible_facts['distribution'] == "Debian"
   tags:
@@ -187,39 +195,45 @@
   ansible.builtin.template:
     src: etc/apt/apt.conf.d/50unattended-upgrades.j2
     dest: /etc/apt/apt.conf.d/50unattended-upgrades
-    backup: yes
+    backup: true
     owner: root
     group: root
-    mode: 0644
+    mode: "0644"
   when:
     - ansible_facts['distribution'] == "Debian"
   tags:
     - unattended-upgrades
 
-
 # ----------
 # - /etc/hosts
 # ----------
 
 - name: (basic.yml) Check file '/etc/hosts.ORIG' exists
-  stat:
+  ansible.builtin.stat:
     path: /etc/hosts.ORIG
-  register: etc_hosts_ORIG
+  register: common_etc_hosts_orig
   when:
     - "groups['file_server']|string is search(inventory_hostname)"
   tags:
     - etc_hosts
 
 - name: (basic.yml) Backup installation version of file '/etc/hosts'
-  command: cp -a /etc/hosts /etc/hosts.ORIG
+  ansible.builtin.copy:
+    src: /etc/hosts
+    dest: /etc/hosts.ORIG
+    remote_src: true
+    force: false
+    owner: root
+    group: root
+    mode: "0644"
   when:
     - "groups['file_server']|string is search(inventory_hostname)"
-    - etc_hosts_ORIG.stat.exists == False
+    - not common_etc_hosts_orig.stat.exists
   tags:
     - etc_hosts
 
 - name: (basic.yml) addjust '/etc/hosts' add nis-server ..
-  lineinfile:
+  ansible.builtin.lineinfile:
     path: /etc/hosts
     regexp: '^192\.168\.'
     line: '{{ nis_server_address }} {{ nis_server_name }} {{ nis_server_name.split(".")[0] }}'
@@ -227,4 +241,3 @@
     - "groups['nis_server']|string is search(inventory_hostname)"
   tags:
     - etc_hosts
-