update..

roles/common/templates/etc/samba/smb.conf.j2

@@ -304,25 +304,56 @@
 {% for item in samba_shares | default([]) %}
 
 [{{ item.name }}]
+{%  if item.comment is defined and item.comment|length > 0 %}
+   comment = {{ item.comment }}
+{%  else %}
    comment = {{ item.name }}
+{% endif %}
    path = {{ item.path }}
 
+{%  if item.browseable is defined and item.browseable|length > 0 %}
+   browseable = {{ item.browseable|string }}
+{%  else %}
    browseable = yes
+{%  endif %}
+{%  if item.read_only is defined and item.read_only|length > 0  %}
+   read only = {{ item.read_only|string }}
+{%  else %}
    read only = no
-   writeable = Yes
+{%  endif %}
+{%  if item.writeable is defined and item.writeable |length > 0 %}
+   writeable = {{ item.writeable }}
+{%  else %}
+   writeable = yes
+{%  endif %}
 
+{%  if item.guest_ok is defined and item.guest_ok|length > 0  %}
+   guest ok = {{ item.guest_ok }}
+
+{%    endif %}
    create mask = {{ item.file_create_mask | default('0660') }}
    force create mode = {{ item.file_create_mask | default('0660') }}
    directory mask = {{ item.dir_create_mask | default('2770') }}
    force directory mode = {{ item.dir_create_mask | default('2770') }}
 
+{%-  if item.valid_users is defined and item.valid_users|length > 0 %}
+
+   # can login into that share
+   valid users = {{ item.valid_users }}
+{%  elif item.group_valid_users is defined and item.group_valid_users|length > 0 %}
+
    # can login into that share
    valid users = @{{ item.group_valid_users }}
+{%    endif %}
+{%-  if item.group_write_list is defined and item.group_write_list|length > 0 %}
+
    # allow to write
    write list = @{{ item.group_write_list }}
 
    force group = +{{ item.group_write_list }}
+{%    endif %}
 {%   if item.vfs_object_recycle is defined and item.vfs_object_recycle|bool %}
+{%      if item.recycle_path is defined and item.recycle_path|length > 0  %}
 
    vfs objects = recycle
    recycle:keeptree = yes
@@ -352,8 +383,13 @@
    # - included in the entry. '*' and '?' can be used to  specify multiple files or
    # - directories as in DOS wildcards.
    # -
-   veto files = /.Trash/
+   veto files = /{{ item.recycle_path | default('@Recycle.Bin') }}/.DS_Store/
    delete veto files = yes
+{%       else %}
+
+{%       endif %}
+{%    else %}
+
 {%    endif %}
 
 {% endfor %}